feat(actions): add nuget trusted publishing #6788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR, @micheloliveira-com. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR enhances the NuGet package publishing workflow by enabling GitHub’s OIDC token, integrating the NuGet/login@v1 action with a secrets-based username, and swapping the static API key for a dynamically obtained key to support NuGet’s Trusted Publishing feature. Sequence diagram for NuGet Trusted Publishing workflowsequenceDiagram
participant Workflow as "GitHub Actions Workflow"
participant NuGetLogin as "NuGet/login@v1 Action"
participant NuGetOrg as "NuGet.org"
participant Secrets as "GitHub Secrets"
Workflow->>NuGetLogin: Request login with secrets.NUGET_USER
NuGetLogin->>Secrets: Retrieve NUGET_USER
NuGetLogin->>NuGetOrg: Authenticate using OIDC token
NuGetOrg-->>NuGetLogin: Return temporary NUGET_API_KEY
NuGetLogin-->>Workflow: Output NUGET_API_KEY
Workflow->>NuGetOrg: Publish package using NUGET_API_KEY
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Blocking issues:
- An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload. (link)
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `.github/workflows/pack.yml:25` </location>
<code_context>
uses: NuGet/login@v1
</code_context>
<issue_to_address>
**security (yaml.github-actions.security.third-party-action-not-pinned-to-commit-sha):** An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload.
*Source: opengrep*
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
Author
|
@ArgoZhang Hello. I think remaining without a SHA hash on Fixing a SHA may break in some future core NuGet changes as well. |
Member
|
@micheloliveira-com thanks for your PR. We are completing the GitHub Star Achievement task, could you give this project a star? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6788 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 739 739
Lines 31721 31721
Branches 4464 4464
=========================================
Hits 31721 31721
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ArgoZhang
approved these changes
Sep 27, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements NuGet Trusted Publishing for enhanced security in package deployment, replacing traditional long-lived API keys with ephemeral tokens generated through OpenID Connect authentication.
- Add
id-token: writepermission to enable OIDC token generation - Integrate NuGet/login action to obtain temporary API keys using GitHub's trusted publishing
- Update environment variable to use the ephemeral API key from the login step
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| BootstrapBlazor.slnx | Add GitHub Actions workflow files to solution structure |
| .github/workflows/pack.yml | Implement NuGet trusted publishing with OIDC authentication |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
|
@source-ai review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixed #6791
Summary By Copilot
Motivation
As described in the official announcement, the new Trusted Publishing feature greatly enhances package publishing security on NuGet.org.
We successfully tested this approach with our own NuGet library:
Required changes in this repository
secrets.NUGET_USERto this repository, using the NuGet.org username (profile name) of the package owner (BootstrapBlazor in this case).secrets.NUGET_API_KEYsecret can be removed from this repository and also from the NuGet.org account if it was only used here.One-time configuration on NuGet.org
According to the documentation:
BootstrapBlazor).dotnetcore).BootstrapBlazor)..github/workflows/(e.g.pack.yml).This setup eliminates the need for long-lived API keys and improves the overall security of the publishing process.
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enable secure package publishing to NuGet.org by integrating the new Trusted Publishing workflow with id-token permissions and ephemeral credentials.
New Features:
Enhancements: